RFR: 8221894: Add comments for docker tests in the test doc

Erik Joelsson erik.joelsson at oracle.com
Wed Apr 3 14:00:38 UTC 2019


Hello Jie,

I think this kind of information would fit better under its own new 
heading to make it more explicit. Then we could continue filling in 
other similar notes for other tests there. At the bottom, something like:

## Notes for Specific Tests

### Docker Tests

<Add basically what you put in the review email here>


What do you think?

/Erik

On 2019-04-03 00:49, Jie Fu wrote:
> Hi all,
>
> JBS:    https://bugs.openjdk.java.net/browse/JDK-8221894
> Webrev: http://cr.openjdk.java.net/~jiefu/8221894/webrev.00/
>
> This is a follow on from 8221342 to add comments for docker tests.
>
> The docker tests with default parameters may fail on the os newer than 
> oraclelinux 7.6.
> For example, it is passed on Ubuntu 16.04 but failed on Ubuntu 18.04 with
> ------------------------------
> make test TEST="jtreg:test/hotspot/jtreg/runtime/containers/docker"
> ------------------------------
>
> To run these tests correctly, the correct docker image parameters are 
> required on Ubuntu 18.04 by using "JAVA_OPTIONS".
> ------------------------------
> make test TEST="jtreg:test/hotspot/jtreg/runtime/containers/docker" 
> JTREG="JAVA_OPTIONS=-Djdk.test.docker.image.name=ubuntu 
> -Djdk.test.docker.image.version=latest"
> ------------------------------
>
> It would be helpful to add these comments.
>
> Could you please review this change?
> The testing.html is updated automatically using "make 
> update-build-docs" with pandoc version 2.7.1.
> Thanks a lot.
>
> Best regards,
> Jie
>
>


More information about the build-dev mailing list