RFR (S): 8221880: Better customization for Windows RC properties FileDescription and ProductName

Erik Joelsson erik.joelsson at oracle.com
Thu Apr 4 18:41:32 UTC 2019


This looks good to me and should work continue to work for us.

/Erik

On 2019-04-04 08:36, Langer, Christoph wrote:
> Hi Erik,
>
>>> Good. Then we are back at my latest webrev:
>> http://cr.openjdk.java.net/~clanger/webrevs/8221880.1/
>>
>> Ah, right, this change does not remove JDK_RC_PLATFORM_NAME from
>> version-numbers, but it does remove it from spec.gmk.in. Could you leave
>> it in spec.gmk.in? Then you can commit this at your own time.
> Then we'd go like this: http://cr.openjdk.java.net/~clanger/webrevs/8221880.2/
>
> Using "\$(JDK_RC_NAME)" instead of "\$(PRODUCT_NAME) \$(JDK_RC_PLATFORM_NAME)" in flags-other.m4 is alright then?
>
> /Christoph
>


More information about the build-dev mailing list