RFR: 8221894: Add comments for docker tests in the test doc
fujie at loongson.cn
Mon Apr 8 03:44:57 UTC 2019
Thank you for your review and very nice suggestions.
Here is the updated version:
Thanks a lot.
On 2019/4/4 下午9:41, Erik Joelsson wrote:
> Hello Jie,
> Looks good, just some grammatical notes on the first paragraph. Here
> is my suggestion:
> Docker tests with default parameters may fail on OS versions newer
> than oraclelinux 7.6.
> For example, they pass on Ubuntu 16.04 but fail on Ubuntu 18.04 if run
> like this:
> On 2019-04-03 20:10, Jie Fu wrote:
>> Hi Erik,
>> Thank you for your review.
>>> Hello Jie,
>>> I think this kind of information would fit better under its own new
>>> heading to make it more explicit. Then we could continue filling in
>>> other similar notes for other tests there. At the bottom, something
>>> ## Notes for Specific Tests
>>> ### Docker Tests
>>> <Add basically what you put in the review email here>
>>> What do you think?
>> Very good suggestions.
>> Here is the updated version:
>> Please review.
>> Thanks a lot.
>> Best regards,
More information about the build-dev