RFR (S): 8221979: Cleanups for building Windows resources
christoph.langer at sap.com
Wed Apr 10 12:21:00 UTC 2019
I already checked and will check carefully once again before pushing.
> -----Original Message-----
> From: Erik Joelsson <erik.joelsson at oracle.com>
> Sent: Dienstag, 9. April 2019 15:22
> To: Langer, Christoph <christoph.langer at sap.com>; build-
> dev at openjdk.java.net; hotspot-dev at openjdk.java.net; core-libs-dev
> <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR (S): 8221979: Cleanups for building Windows resources
> Looks ok to me.
> I assume you have inspected all affected files and made sure all
> attributes are the same pre and post this change?
> On 2019-04-09 02:55, Langer, Christoph wrote:
> > Hi,
> > during work on JDK-8221880 I spotted some opportunity for cleanup in
> Windows resource files and their handling in the build.
> > The naming of variables used for customizing resource properties in the
> build system should be aligned between hotspot and JDK. This should be
> carefully reviewed by the build team (Erik). Maybe there are conflicts with
> some Oracle internal usage of variables...
> > Furthermore some minor stuff:
> > There are some indentation issues in the rc files.
> C uses RC in capital letters as suffix, which is different to all other .rc files
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8221979
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8221979.0/
> > Thanks
> > Christoph
More information about the build-dev