[DMARC FAILURE] RFR (XS): 8222510: Small cleanup for JDK launcher's make file

Langer, Christoph christoph.langer at sap.com
Tue Apr 16 06:09:36 UTC 2019

Hi Man,

the change looks good to me, thanks for doing this cleanup.

As for reviewers: I thought it depends whether the author of a change is a Reviewer himself. Then only one Reviewer needs to review the change. But I might be wrong here. So, let's wait for a review from the build group and maybe these folks can answer this question, too.

Best regards

> -----Original Message-----
> From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of Man
> Cao
> Sent: Dienstag, 16. April 2019 04:04
> To: build-dev at openjdk.java.net
> Subject: [DMARC FAILURE] RFR (XS): 8222510: Small cleanup for JDK
> launcher's make file
> Hi,
> Can I have reviews for this small cleanup? It basically removes some dead
> and redundant variables and updates comment.
> Webrev: https://cr.openjdk.java.net/~manc/8222510/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222510
> I found these issues while working on the tsan project (
> http://hg.openjdk.java.net/tsan/dev/). Some relevant changes previously
> touched the code include JDK-8210931, JDK-8199639, JDK-8141444.
> And do I need only one review for this change? It seems many build files
> changes only have one reviewer.
> -Man

More information about the build-dev mailing list