RFR (XS): 8222510: Small cleanup for JDK launcher's make file

Man Cao manc at google.com
Tue Apr 16 21:09:43 UTC 2019


Thank everyone for the reviews and discussion!

-Man


On Tue, Apr 16, 2019 at 6:37 AM Erik Joelsson <erik.joelsson at oracle.com>
wrote:

> Hello Man,
>
> The cleanup looks good, consider it reviewed. I do wonder if the removal
> of LDFLAGS_solaris in JDK-8210931 was intentional, but since no problems
> seem to have arisen from it, I guess it doesn't matter at this point.
>
> Regarding reviewers, for build changes, we only require one, because we
> are so few in the build group so it would be impractical to require
> more. We do like to always have someone from the build group review all
> changes that touch any part of the build system though.
>
> /Erik
>
> On 2019-04-15 19:04, Man Cao wrote:
> > Hi,
> >
> > Can I have reviews for this small cleanup? It basically removes some dead
> > and redundant variables and updates comment.
> > Webrev: https://cr.openjdk.java.net/~manc/8222510/webrev.00/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8222510
> >
> > I found these issues while working on the tsan project (
> > http://hg.openjdk.java.net/tsan/dev/). Some relevant changes previously
> > touched the code include JDK-8210931, JDK-8199639, JDK-8141444.
> >
> > And do I need only one review for this change? It seems many build files
> > changes only have one reviewer.
> >
> > -Man
>


More information about the build-dev mailing list