RFR: JDK-8221988: add possibility to build with Visual Studio 2019

Aleksei Voitylov aleksei.voitylov at bell-sw.com
Thu Apr 18 14:19:55 UTC 2019


Hi,

Though the fix itself is trivial, testing took some time. Sorry about 
that. I'd suggest to have Yasamasa Suenaga included as one of the 
authors of this patch as we crossed working in parallel on this and he 
provided valuable input on build testing on WSL. I'm equally fine if the 
patch from Yasamasa in this list above is taken, in which case I can 
submit another patch for devkit.

Please review this fix to enable build with Visual Studio 2019. For 
Windows x86_64 this is a seamless migration, but I suggest to keep VS 
2017 as the only supported and default for now. For those interested in 
VS 2019 runtime binary compatibility details, please refer to section 
"VC Runtime in the latest MSVC v142 toolset is binary compatible with 
v140 and v141" in [1].

webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8221988.01/
issue: https://bugs.openjdk.java.net/browse/JDK-8221988

Build testing:

Windows x86_64 product and fastdebug build on Windows 2012R2.
Yasumasa Suenaga also reported successfully building on WSL.

Testing:

Windows 7, 10, 2012R2, 2016, 2019 64-bit jtreg with no regressions.
generated devkit was used to build JDK 11 and test JCK and jtreg, with 
no regressions.

I'm working on fixing Windows 32-bit with VS 2019 in a separate issue [2].

Thanks,

-Aleksei

[1] 
https://devblogs.microsoft.com/cppblog/cpp-binary-compatibility-and-pain-free-upgrades-to-visual-studio-2019/
[2] https://bugs.openjdk.java.net/browse/JDK-8222726



More information about the build-dev mailing list