RFR: 8219920: dependency help output in configure-step : support zypper tool

Erik Joelsson erik.joelsson at oracle.com
Mon Mar 4 17:20:53 UTC 2019


Hello,

I noted that you put zypper first in help.m4, but apt-get is still ahead 
in configure. I think we should try to keep them in the same order in 
both files. Otherwise this looks good.

/Erik

On 2019-03-04 06:40, Baesken, Matthias wrote:
> Hi Magnus  , I tested a bit more  on a recent OpenSUSE Leap 15  with not many packages  installed .
>
> I observed  some things :
>
>
>    *   Latest OpenSUSE Leap 15   had “apt-get” as well  additionally  to zypper   ; however  the apt-get Ubuntu  package   names do not help much on SUSE -  so I put zypper  in the search list in front of apt-get
>    *   Zypper package names were okay , the helpful output I got  (for cups / alsa / x11 ) was correct
>    *    I added the gcc/g++  packages as well   ( you usually  run into this on a “fresh” system without gcc )
>
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219920.1/
>
>
> Best regards, Matthias
>
>
> From: Baesken, Matthias
> Sent: Freitag, 1. März 2019 15:17
> To: 'Magnus Ihse Bursie' <magnus.ihse.bursie at oracle.com>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
> Cc: Simonis, Volker <volker.simonis at sap.com>; Zeller, Arno <arno.zeller at sap.com>
> Subject: RE: RFR: 8219920: dependency help output in configure-step : support zypper tool
>
> Hi Magnus ,
>
>
>    *   Have you verified that this actually works? E.g. by starting in a fresh SUSE installation, running configure,
>    *   and then running the corresponding line and noticing that this helped configure get further on? Or did you just copy the yum/apt package names?
>
> A bit of  both  ��  .
> I had  2 Linux  installs  with incomplete  packages  (e.g. cups and  X-related stuff was missing).
> I  added the names  with the “missing …”  output   from  those 2  Linux  installs  with incomplete  packages  .
>
> However some packages we depend on  were already  available .
>
> If you want I could  try to test on a  fresh   OpenSUSE .
>
>
> Best regards,
>           Matthias
>
>
> From: Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com<mailto:magnus.ihse.bursie at oracle.com>>
> Sent: Freitag, 1. März 2019 14:44
> To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>>
> Cc: Simonis, Volker <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>; Zeller, Arno <arno.zeller at sap.com<mailto:arno.zeller at sap.com>>
> Subject: Re: RFR: 8219920: dependency help output in configure-step : support zypper tool
>
> On 2019-02-28 13:53, Baesken, Matthias wrote:
>
> Hello, please review the following  change .
>
>
>
> Currently  the  configure-step  outputs  help  for  a number of  packages + related installation calls  in case of missing dependencies  (like cups / alsa etc.) .
>
> This help output step   covers a few  tools (like apt-get).
>
>
>
>
>
> However the OpenSUSE / SLES tool zypper  is not supported .
>
> This  change adds  output for  zypper .
>
>
>
> Bug/webrev:
>
>
>
> https://bugs.openjdk.java.net/browse/JDK-8219920
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8219920.0/
>
> Thank you for making the OpenJDK configure system even more self-helping!
>
> This looks good to me.
>
> Have you verified that this actually works? E.g. by starting in a fresh SUSE installation, running configure, and then running the corresponding line and noticing that this helped configure get further on? Or did you just copy the yum/apt package names?
>
> /Magnus
>
>
>
>
>
>
>
> Thanks, Matthias
>


More information about the build-dev mailing list