RFR: JDK-8214566 : --win-dir-chooser does not prompt if destination folder is not empty

Erik Joelsson erik.joelsson at oracle.com
Fri Mar 8 14:26:28 UTC 2019


Build changes look good.

/Erik

On 2019-03-07 14:52, Alexander Matveev wrote:
> Hi Erik,
>
> http://cr.openjdk.java.net/~almatvee/8214566/webrev.01/
>
> - Removed $(call SET_SHARED_LIBRARY_ORIGIN), TOOLCHAIN_LINK_CXX and 
> linking with libjava.
>
> Thanks,
> Alexander
>
> On 3/7/2019 6:52 AM, Erik Joelsson wrote:
>> Hello Alexander,
>>
>> A few notes:
>>
>> $(call SET_SHARED_LIBRARY_ORIGIN) and TOOLCHAIN_LINK_CXX have no 
>> effect on Windows, so should be removed to avoid confusion in the 
>> future.
>>
>> This new library does not link with libjava so I see no need to add 
>> that prerequisite declaration.
>>
>> /Erik
>>
>> On 2019-03-06 17:10, Alexander Matveev wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>> repository (jpackage).
>>>
>>> - Added custom action to check installation folder and display 
>>> confirmation dialog to ask user to continue installation if 
>>> destination folder is not empty. This is same behavior and 
>>> confirmation message as for .exe.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8214566
>>>
>>> [2] http://cr.openjdk.java.net/~almatvee/8214566/webrev.00/
>>>
>>> Thanks,
>>> Alexander
>


More information about the build-dev mailing list