Fwd: [RFR] [8u] 8220397: JDK-8036003 backport regresses no_strip builds

Andrew John Hughes gnu.andrew at redhat.com
Thu Mar 14 00:27:47 UTC 2019


Forwarding to build-dev for wider review.

-------- Forwarded Message --------
Subject: [RFR] 8220397: JDK-8036003 backport regresses no_strip builds
Date: Mon, 11 Mar 2019 07:33:16 +0000
From: Andrew John Hughes <gnu.andrew at redhat.com>
To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>

Bug: https://bugs.openjdk.java.net/browse/JDK-8220397
Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8220397/webrev.01/

When JDK-8036003 was backported, it added a bunch of conditionals in
make/common/NativeCompilation.gmk which cause debuginfo to not be
generated if no_strip is set. However, the cases for ZIP_DEBUGINFO_FILES
were missed, causing the build to fail, because there's no dependency
for the .diz target.

I suspect this doesn't show up when the new configure option is
specified, because ZIP_DEBUGINFO_FILES is toggled appropriately, but it
does regress my existing builds which don't specify that option.

Simple fix and 8u only.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew





More information about the build-dev mailing list