RFR [11u] : 8221318: [11u] do not disable c99 on Solaris

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Mar 22 10:08:00 UTC 2019


Looks good to me, thanks for downporting.

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Langer, Christoph
> Sent: Freitag, 22. März 2019 10:32
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'build-
> dev at openjdk.java.net' <build-dev at openjdk.java.net>; jdk-updates-
> dev at openjdk.java.net
> Subject: [CAUTION] RE: RFR [11u] : 8221318: [11u] do not disable c99 on
> Solaris
> 
> Hi Matthias,
> 
> first of all: The change looks good to me, +1.
> I assume you have run it through our build/test infrastructure and see no
> regressions...
> 
> As for the process:
> In your case, you want to backport a change and the original patch does not
> apply cleanly. For that scenario, you don't have to create a new bug (as JDK-
> 8221318 in your case). You should just ask for review under the original bug id
> (JDK-8215710). When you have reviews and push approval, you need to push
> the change with the original patch message, referencing the original bug (JDK-
> 8215710). The hgupdater daemon will then create a new backport bug and
> creates the according links.
> 
> For your case, I've set fix version of JDK-8221318 to 11-pool. Then hgupdater
> will pick it up and resolve it for the right release. Maybe you ping me, when
> you're going to push, then we can check things together ��
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of
> > Baesken, Matthias
> > Sent: Freitag, 22. März 2019 09:50
> > To: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; jdk-
> > updates-dev at openjdk.java.net
> > Subject: [CAUTION] RFR [11u] : 8221318: [11u] do not disable c99 on Solaris
> >
> > Hello, please review this change.
> >
> > It is a downport of   jdk13 change
> > https://bugs.openjdk.java.net/browse/JDK-8215710     to  11u .
> >
> > JDK-8215710  removed the disabling of C99 on Solaris in jdk13.
> > Reason was :
> > "Currently we disable C99 in the Solaris build by setting -xc99=%none%.
> > This differs from a lot of other build environments like gcc/Linux or
> > VS2013/2017 on Windows where C99 features work.
> > We should remove this difference on Solaris and remove or replace the
> > setting. "
> >
> >
> > It would be helpful to have this downported to jdk11, because it would make
> > downporting changes easier (brings build settings of the releases closer
> > together) .
> > (I was already  running  into   one issue   because  of the  different build
> > settings )
> >
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8221318
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8221318.0/
> >
> >
> > Thanks, Matthias


More information about the build-dev mailing list