RFR: JDK-8221179: Zero builds fail when linking with gold and bundling libffi.so

Tim Bell tim.bell at oracle.com
Fri Mar 22 14:02:13 UTC 2019


Erik:

On 03/22/19 02:17, Severin Gehwolf wrote:
> On Thu, 2019-03-21 at 09:05 -0700, Erik Joelsson wrote:
>> This patch adds a missing RPATH to libjvm.so which is needed when
>> bundling libffi.so for zero builds. The rpath is only added when
>> building zero and bundling of libffi is enabled. When linking with bfd
>> (the old binutils linker), it seems that the rpath of the library that
>> loaded libjvm.so (libjli.so) is implicitly still active, so this isn't a
>> problem. At Oracle we recently switched to the gold linker and then the
>> implicit rpath is no longer in effect.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221179
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8221179/webrev.01/
>
> This looks OK to me. I'm not a Reviewer.
>
> Thanks,
> Severin

Looks good to me as well.

Tim



More information about the build-dev mailing list