[RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

Andrew John Hughes gnu.andrew at redhat.com
Thu Mar 28 03:56:51 UTC 2019


On 26/03/2019 21:57, Langer, Christoph wrote:
> Hi Andrew,
> 
> thanks for doing this backport. I agree, Severin's finding needs to be added to hotspot's Unix/Posix vm.make files.

Yes, it was missed because it's already there prior to this patch in the
9 and up HotSpot build which is quite different. It also seems to
require a change to vm_version.cpp so the value isn't double-quoted.

> 
> Also, the additional printing of those variables in the Unixish buildtree.make files should be added to windows' make/windows/build.make in target $(variantDir)\local.make.

Ah, I was looking for the equivalent but it's odd that it's not in
make/windows, and so didn't show up with grep.

Revised HotSpot webrev:

https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the build-dev mailing list