[RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

Andrew John Hughes gnu.andrew at redhat.com
Fri Mar 29 06:18:28 UTC 2019



On 28/03/2019 09:30, Langer, Christoph wrote:
> Hi,
> 
>>> Revised HotSpot webrev:
>>>
>>> https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02
>>
>> +++ new/src/share/vm/runtime/vm_version.cpp	2019-03-28
>> 03:52:51.384737947 +0000
>> @@ -140,7 +140,7 @@
>>
>>  const char* Abstract_VM_Version::vm_vendor() {
>>  #ifdef VENDOR
>> -  return XSTR(VENDOR);
>> +  return VENDOR;
>>
>> This looks like the change from JDK-8200115. Have you considered
>> backporting this separately? Failing that, we should mention JDK-
>> 8200115 in the backport commit message as well.
> 
> I suggest inlining the backport of 8200115 to this commit by adding "8200115: System property java.vm.vendor value includes quotation marks" to the commit message. It will resolve/backport 8200115 as well. Process wise we should probably tag 8200115 with jdk8u-critcal-request and get it approved, though?
> 
> Please also update the copyright years accordingly when pushing.
> 
> Thanks & Best regards
> Christoph
> 

Revised version without 8200115 & with copyright updates:

https://cr.openjdk.java.net/~andrew/openjdk8/8189761/webrev.02/

I bumped the existing copyright where the change was from the original
patch. I added our copyright where the changes were unique to this
backport (HotSpot only).
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the build-dev mailing list