hg: jdk7/tl/jdk: 4116222: Errors in Arabic code-conversion tables, part II

Ulf Zibis Ulf.Zibis at gmx.de
Sat Aug 15 08:51:55 PDT 2009

Hi Sherman,

I've seen, that you have again changed GenerateSBCS.java

I like to remember to review my changes on:

IMHO my code is much smarter, and faster too (saves JDK build time), + 
you can simply copy the principle to all other GenerateX.java.
(It's fast, because of direct formatting to file, instead of first 
replacing long String's range-wise.)

Additionally I've fixed a small bug regarding c2bLength calculation:
  If there is:
  0x01 0x0101
  0x02 0x0202
  0x03 0x0303

  0x03 0x0303

  ... c2bLength was calculated to 0x300, but should be 0x200.


Am 04.08.2009 22:00, xueming.shen at sun.com schrieb:
> Changeset: c390fd8fa885
> Author:    sherman
> Date:      2009-08-04 12:44 -0700
> URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c390fd8fa885
> 4116222: Errors in Arabic code-conversion tables, part II
> Summary: updated the IBM420 datatable
> Reviewed-by: alanb
> ! make/tools/CharsetMapping/IBM420.c2b
> ! make/tools/CharsetMapping/IBM420.map
> ! make/tools/CharsetMapping/IBM420.nr
> ! make/tools/src/build/tools/charsetmapping/GenerateSBCS.java

More information about the compiler-dev mailing list