[PATCH FOR REVIEW]: Make source/target options explicit for def-pcompile

Jonathan Gibbons Jonathan.Gibbons at Sun.COM
Tue Aug 18 15:28:33 PDT 2009

Andrew John Hughes wrote:
> The def-pcompile Ant target in the langtools build does not explicitly
> set the source and target options for javac.  As a result, the class
> files will be built using the default versions of the javac forked by
> Ant.  If this is < 1.5, the build will fail (this is the case with
> ecj, for example).
> The webrev:
> http://cr.openjdk.java.net/~andrew/ecj/01/webrev.01/
> fixes this by making the values explicit (using the boot source and
> target values, currently 1.6).
> Ok to push to tl?

Yes, and please push the same fix to jdk6 as well, to keep the two build 
files in

> Thanks,

-- Jon

More information about the compiler-dev mailing list