hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

Andrew John Hughes gnu_andrew at member.fsf.org
Fri Aug 21 12:35:24 PDT 2009

2009/8/21 Mark Wielaard <mark at klomp.org>:
> Hi Mark,
> On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote:
>> This change was integrated prematurely.  I've rolled it back in the
>> jdk7/tl/jdk repository.
> If at all possible, please don't do this. It plays havoc with already
> checked out repos and/or automatic clones/backups. You force people to
> recreate their local repos if you purge a commit that was already public
> like this. Could you use a normal hg backout instead in the future? That
> will make sure the integrity of the repo isn't compromised.

It would be much cleaner to just do a commit reversing the patch (mjw,
is that what you mean by a backout or something else?)

I really don't like the idea of sanitising the repos to remove all
mistakes and there's also no guarantee everyone will do this and push
it in every forest.

> Thanks,
> Mark

Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

More information about the compiler-dev mailing list