RFR for JDK-8028708. Tests Tests should pass through VM options
vicente.romero at oracle.com
Mon Dec 9 11:14:53 PST 2013
On 09/12/13 16:32, Jonathan Gibbons wrote:
> On 12/09/2013 08:03 AM, Andrey Nazarov wrote:
>> Hi everyone,
>> I'm fixing following tests.
>> Tests should pass through VM options.
>> Root cause:
>> VM options are not passed to java executed by java programs.
>> SUGGESTED FIX:
>> Add System.getProperty("test.vm.opts","") and
>> System.getProperty("test.java.opts","") to invocations of the java
>> cmd for *.java tests.
> The fix is OK, but in general it is not important to be able to run
> javac tests under a variety of externally provided JVM options. Do
> you have a particular reason for the fix?
> Since you've written the same code 3 times in ToolBox.java, you might
> want to use a shared utility method instead.
> -- Jon
I can also see that the tests need to have a path to bin/java this is
also provided by Toolbox through the static field javaBinary.
More information about the compiler-dev