RFR : 8016577 : (s) langtools/test/Makefile should only set some vars if unset

Mike Duigou mike.duigou at oracle.com
Thu Jun 13 13:11:11 PDT 2013

Hello all;

I have been working on improving the execution of tests via the root repo "make test" target (JDK-8009683). This work has so far mostly concerned the jdk repo but now I would like to increase the commonality of the test/Makefile for the various repos.

In the langtools/test/Makefile these vars are 


currently unconditionally set. They should only be set if they don't already have definitions. This is part of an effort to retire some of the JPRT specific vars and synchronize the jdk and langtools test/Makefile


- JTREG_HOME is renamed to JT_HOME for consistency 

- TESTBOOTCLASSPATH setting is made more uniform, ie. not just when PRODUCT_HOME is defined.

- Warnings are now printed for variables using the default "unset" value. In most cases these variable *should* already have a value so no default should be used. For now the defaults are retained but with a warning.

- An error is generated if PRODUCT_HOME seems to point at an invalid location.

A review webrev is posted here:


Once this issue is completed I will follow up with JDK-8016573 which will replace JPRT_JAVA_HOME with JT_JAVA in the Main.gmk make file.



More information about the compiler-dev mailing list