Review request for JDK-8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters

Jonathan Gibbons jonathan.gibbons at
Fri Jun 14 12:46:20 PDT 2013

The change to Gen looks OK, but the tests look weak.  At a minimum, I 
would expect to see the test check the validity of the error message 
that is generated; even better would be to generate the test cases on 
the fly.

-- Jon

On 06/14/2013 11:29 AM, Eric McCorkle wrote:
> Hello,
> Please review this patch, which addresses a problem with javac not
> taking inner this parameters into account when determining if there are
> too many parameters to a function.
> The webrev is here:
> The bug report is here:
> Thanks,
> Eric

More information about the compiler-dev mailing list