Review request for JDK-8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters

Eric McCorkle eric.mccorkle at
Wed Jun 19 12:08:16 PDT 2013

Added a new constructor to Main that allows tests to pass in their own
Log, facilitating much more precise tests of what errors the compilers

I also rolled all the arg limit tests into a general framework.

Webrev is here:

On 06/14/13 16:30, Jonathan Gibbons wrote:
> There are two solutions.
> For a one-off test, the standard technique is to use a golden file
> in conjunctions with rawDiagnostics.   The combination is
> "somewhat frail" but nowhere near "incredibly frail".  The technique
> has served us well for many years now.
> If you are driving javac through the Compiler API, you can register
> a DiagnosticListener, and verify the characteristics of the Diagnostic
> objects passed to report.
> -- Jon
> On 06/14/2013 01:14 PM, Eric McCorkle wrote:
>> Is there a more convenient API for checking error messages?  Golden will
>> make for an incredibly frail test, I think.
>> On 06/14/13 15:46, Jonathan Gibbons wrote:
>>> The change to Gen looks OK, but the tests look weak.  At a minimum, I
>>> would expect to see the test check the validity of the error message
>>> that is generated; even better would be to generate the test cases on
>>> the fly.
>>> -- Jon
>>> On 06/14/2013 11:29 AM, Eric McCorkle wrote:
>>>> Hello,
>>>> Please review this patch, which addresses a problem with javac not
>>>> taking inner this parameters into account when determining if there are
>>>> too many parameters to a function.
>>>> The webrev is here:
>>>> The bug report is here:
>>>> Thanks,
>>>> Eric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
Url : 

More information about the compiler-dev mailing list