Review request for JDK-8016760: failure of regression test langtools/tools/javac/

Jonathan Gibbons jonathan.gibbons at
Tue Jun 25 12:04:32 PDT 2013


Making the test pass in the short term by working around the problem 
does not seem a reasonable thing to do.

-- Jon

On 06/25/2013 10:50 AM, Xueming Shen wrote:
> This is fine to be a workaround for the test case for now. It probably 
> will need to be
> undo-ed after the propose change for #8015666 get integrated.
> The proposal for #8015666 is to keep the "existing" behavior of 
> ZipEntry.getTime()
> to return a LastModifiedTime converted from the zip entry's 
> ms-dos-formatted date/time
> field by using the "default" timezone. A new pair 
> ZipEntry.get/setLastModifiedTime()
> will be added to access the "real" UTC time stored in the zip entry, 
> if presents.
> The API doc will be updated accordingly as well to explicitly explain 
> the source of the
> date/time and the its timezone sensitive conversion.
> -Sherman
> On 06/25/2013 07:03 AM, Eric McCorkle wrote:
>> Hello,
>> Please review this simple patch which updates regression test
>> langtools/tools/javac/ to offset the time returned by
>> JavaFileObject.getLastModified() with the local time to UTC delta.
>> Please note that this patch is intended to address the test failures,
>> and that I will be immediately opening a new bug to investigate and
>> address deeper issues, and also to properly document the API.
>> The webrev is here:
>> The bug report is here:
>> Thanks,
>> Eric

More information about the compiler-dev mailing list