Public review of rearchitected front-end type annotations pipeline
wdietl at gmail.com
Fri May 9 20:20:28 UTC 2014
two quick questions:
- I don't see "Stress" anywhere in the patch. Is that test case included?
- Is there a reason to not use @Deprecated for the classes/methods
that will be removed?
Is this a good time to adapt the Checker Framework to these changes or
should I wait for patch 3?
On Fri, May 9, 2014 at 3:49 PM, Eric McCorkle <eric.mccorkle at oracle.com> wrote:
> This is the public review of the second in my series of patches dealing
> with type annotations.
> This patch rearchitects the type annotations pipeline, integrating
> handling of type annotations directly into the javac
> MemberEnter/Annotate/Attr pipeline. It represents the majority of the
> work I have been doing regarding type annotations for 8u20.
> The handling of type annotations is now dispatched by the MemberEnter or
> Attr visitors and uses information from those visitors. Most of the
> actual functionality is now implemented in Annotate.
> The new test Stress.java is the test for this patch. Stress.java will
> cause 8-release javac to fail with an assertion failure. Its addition
> to the test suite demonstrates that this change fixes those cases.
> This patch addresses a number of JBS issues:
> and possibly others as well.
> Note: this patch does not attempt to remove code made obsolete; however,
> any such code is very clearly marked as deprecated. Removal of dead
> code will be done in the last of the series. This patch also does not
> attempt to re-enable tests which were previously disabled. That will be
> done as a separate patch as well.
More information about the compiler-dev