RFR: JDK 8194892: add compiler support for local-variable syntax for lambda parameters

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Wed Feb 14 10:59:06 UTC 2018

Looks good; minor quibbles:

* Changes in ParserFactory and JavacParser (for adding diagnostic 
factory) seem unnecessary?

* the diagnostic say 'explicitly-typed parameters' which is a term that 
also appear in the spec, so good! But they say 'implicit parameters' - 
which is inconsistent both with the other fragment and with the spec. I 
suggest replacing with 'implicitly-typed' parameters.

Would also help to have some snapshot of the new diagnostics being emitted.


On 13/02/18 20:49, Vicente Romero wrote:
> Please review the implementation for JEP 323: Local-Variable Syntax 
> for Lambda Parameters [1].
> The specification has been made public at [2]. The current 
> implementation for the spec can be found at [3].
> Thanks,
> Vicente
> [1] https://bugs.openjdk.java.net/browse/JDK-8193259
> [2] 
> http://mail.openjdk.java.net/pipermail/amber-spec-experts/2018-February/000268.html
> [3] http://cr.openjdk.java.net/~vromero/8194892/webrev.00/

More information about the compiler-dev mailing list