RFR [15] 8236435: Fix typos in javac area

Pavel Rappo pavel.rappo at oracle.com
Fri Dec 20 15:44:50 UTC 2019


Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8236435:


I've been reading up on the javadoc code and comments. At one point, jumping
through the links, I reached the javax.tools.DocumentationTool and
com.sun.tools.javac.util.ClientCodeException, which reside in java.compiler and
jdk.compiler respectively. I found a couple of typos there and fixed them.

One thing led to another and half an hour later I found myself compulsively
checking the full javac code base for typos and spelling. Sigh.

Long story short, I just went ahead and fixed as many issues as I could in one
sitting. There was a lot.

On the bright side, this patch doesn't involve any code changes (except for
spelling in internal variables and methods' parameters), addresses aesthetic
issues, readability, helps with searches and assists IDEs to pick up usages
more reliably when refactoring (e.g. renaming).

The initial concern with DocumentationTool turned out to be more subtle and I
decided not to include it in this patch. It is definitely not just a typo and
might require a CSR.

Please review at your convenience. Hopefully, if there are false positives,
you'll catch them.

I suggest reviewing this change using a diff tool with a character-level
resolution. That is, a tool capable of highlighting mismatching characters in
lines that differ.

All test/langtools tests pass. Copyright years will be fixed before the push.


More information about the compiler-dev mailing list