RFR(13): JDK-8216263: Add historical data for JDK 12
jan.lahoda at oracle.com
Tue Jan 8 10:13:11 UTC 2019
Thanks for the comments, some responses inline. Updated webrev:
On 7.1.2019 23:51, Joseph D. Darcy wrote:
> Hi Jan,
> On 1/7/2019 4:48 AM, Jan Lahoda wrote:
>> To make --release 12 work, we need to add historical data for JDK 12.
>> The current historical data is based on:
>> $ javac -fullversion
>> javac full version "12-ea+26"
>> We may need to update the data once JDK 12 is out to cover any changes
>> to the APIs that might happen.
>> The patch also adds a simple (shell) script to generate the data, so
>> all that was needed to generate the data was:
>> $ cd make/data/symbols
>> $ sh generate-data <path-to-JDK-12>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8216263
>> Webrev: http://cr.openjdk.java.net/~jlahoda/8216263/webrev.00/
>> How does this look?
> If the overhead is small enough and we don't mind a few updates to the
> JDK N+1 data, than perhaps the generation of this information could be
> included as part of the start of JDK N+1 activities.
That would be perfect!
> I suggest a more extensive description of how to
> make/data/symbols/generate-data. For example, this builds the data for
> the current release independent of whether or not the current release
> has already had its data generated, correct?
> Concretely, if JDK N+1 has already forked, what is the proper way to get
> data for JDK N? Likewise, how should a re-build of the data for JDK N be
What exactly should be there? To the existing description:
# to generate (add) data for JDK N, do:
# cd make/data/symbols
# sh generate-data <path-to-JDK-N>
I've added (in .01):
# to regenerate the data for JDK N, run the above commands again
What more should be there?
More information about the compiler-dev