JDK 13 RFR of 8216404: Elements.getPackageOf should handle modules
jan.lahoda at oracle.com
Thu Jan 10 15:25:13 UTC 2019
Looks good to me.
On 9.1.2019 17:45, Joe Darcy wrote:
> Please review the changes and CSR for
> 8216404: Elements.getPackageOf should handle modules
> In summary, the method Elements.getPackageOf was not updated to specify
> how modules should be handled. The javac implementation currently throws
> an NPE in that case.
> The fix is to add a check for that situation in the javac implementation
> of the Elements interface. This could also be added at the Symbol level,
> but adding it to Elements seemed a more direct approach.
More information about the compiler-dev