RFR: JDK-8217335: Add a script to generate --release data

Jan Lahoda jan.lahoda at oracle.com
Fri Jan 18 17:05:59 UTC 2019

Hi Magnus,

Thanks for the comments, an updated webrev:

(Includes changes suggested by Joe was well).


On 18.1.2019 13:59, Magnus Ihse Bursie wrote:
> On 2019-01-17 19:51, Jan Lahoda wrote:
>> Hi,
>> As suggested here:
>> https://mail.openjdk.java.net/pipermail/compiler-dev/2019-January/012876.html
>> This is a separate patch that adds a script to generate --release N data.
>> Webrev: http://cr.openjdk.java.net/~jlahoda/8217335/webrev.00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8217335
>> Jan
> Hi Jan,
> I would recommend that you place the generate-data script in
> make/scripts; it's the default location for scripts -- make/data is
> reserved for, eh, data. :) But a bit more descriptive name would be
> suitable when moving it away from make/data/symbols -- perhaps
> generate-symbol-data?
> Also, the update to the README file does not seem correct. I assume you
> want to point to the new generate-data script, but the path is wrong
> (even for the location in your current patch).
> Finally, we in the build team always appreciates if you cc build-dev for
> changes in the make directory, even if it's not strictly part of the
> build system.
> /Magnus

More information about the compiler-dev mailing list