RFR: JDK-8217335: Add a script to generate --release data
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Mon Jan 21 10:14:23 UTC 2019
On 2019-01-18 18:05, Jan Lahoda wrote:
> Hi Magnus,
> Thanks for the comments, an updated webrev:
> (Includes changes suggested by Joe was well).
Looks good to me!
> On 18.1.2019 13:59, Magnus Ihse Bursie wrote:
>> On 2019-01-17 19:51, Jan Lahoda wrote:
>>> As suggested here:
>>> This is a separate patch that adds a script to generate --release N
>>> Webrev: http://cr.openjdk.java.net/~jlahoda/8217335/webrev.00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8217335
>> Hi Jan,
>> I would recommend that you place the generate-data script in
>> make/scripts; it's the default location for scripts -- make/data is
>> reserved for, eh, data. :) But a bit more descriptive name would be
>> suitable when moving it away from make/data/symbols -- perhaps
>> Also, the update to the README file does not seem correct. I assume you
>> want to point to the new generate-data script, but the path is wrong
>> (even for the location in your current patch).
>> Finally, we in the build team always appreciates if you cc build-dev for
>> changes in the make directory, even if it's not strictly part of the
>> build system.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the compiler-dev