RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms after JDK-8227512
christoph.langer at sap.com
Wed Jul 24 09:44:05 UTC 2019
Hi Alan, Aleksey,
thanks for the reviews.
Here is an update which incorporates all suggestions: http://cr.openjdk.java.net/~clanger/webrevs/8228571.1/
> The update requires.extraPropDefns.bootlibs TEST.ROOT should probably
> include Container.java so that it's consistent with the jdk tests. I realize it's
> unlikely that langtools tests will run docker commands but I'm sure the
> inconsistency will be noticed.
Agreed. I copied that part from an older version of jdk's TEST.ROOT.
> Shouldn't vm.graal.enabled tests include jdk.internal.vm.compiler in the
> @modules list?
It's probably better. I added it.
> I agree with Aleksey about inverting the default for the parameter.
You are right. Please look at my new webrev whether you find it better there.
I tested with both, graal and non-graal configurations and see the relevant test configuration is executed and succeeds. I'll run the fix through our nightlies, too.
More information about the compiler-dev