RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms after JDK-8227512

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Jul 24 16:40:17 UTC 2019

On 7/24/19 3:31 AM, Alan Bateman wrote:
> On 24/07/2019 10:44, Langer, Christoph wrote:
>> Hi Alan, Aleksey,
>> thanks for the reviews.
>> Here is an update which incorporates all suggestions: 
>> http://cr.openjdk.java.net/~clanger/webrevs/8228571.1/
> This looks okay to me but probably best to have someone on 
> compiler-dev okay to change too as that is where the javac tests are 
> maintained. There is an argument that it would be simpler to just have 
> these tests be skipped when testing with Graal.
> -Alan

This seems wrong/misguided/over the top.

On the one hand, javac is a relatively simple Java program that should 
not need to depend on VM internals like this. Conversely, if a Java 
program does need to depend on VM "internals" like this, perhaps they 
should be exposed more publicly and not be "internal".

-- Jon

More information about the compiler-dev mailing list