RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms after JDK-8227512

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Jul 25 14:44:20 UTC 2019


-- Jon

On 7/25/19 6:28 AM, Langer, Christoph wrote:
> Hi,
> after catching up with this discussion, I agree that the most pragmatic fix for now would be to backout JDK-8227512 and add graal specific exclusions.
> That's what I do here: http://cr.openjdk.java.net/~clanger/webrevs/8228571.2/
> If you all agree, I'll create another JBS Bug about the underlying issues regarding this test with limiting modules to jdk.compiler on a graal enabled VM and add that to the problem list entries.
> I also think that it's not the time now to introduce the machinery behind `@requires !vm.graal.enabled` to langtools testing.
> Please let me know what you think.
> Cheers
> Christoph
>> -----Original Message-----
>> From: Pengfei Li (Arm Technology China) <Pengfei.Li at arm.com>
>> Sent: Donnerstag, 25. Juli 2019 06:06
>> To: Igor Ignatyev <igor.ignatyev at oracle.com>; Jonathan Gibbons
>> <jonathan.gibbons at oracle.com>
>> Cc: Alan Bateman <Alan.Bateman at oracle.com>; Langer, Christoph
>> <christoph.langer at sap.com>; compiler-dev at openjdk.java.net; hotspot-
>> compiler-dev at openjdk.java.net; Aleksey Shipilev <shade at redhat.com>;
>> Vladimir Kozlov <vladimir.kozlov at oracle.com>; David Holmes
>> <david.holmes at oracle.com>; nd <nd at arm.com>;
>> daniel.daugherty at oracle.com; Maurizio Cimadamore
>> <Maurizio.Cimadamore at oracle.com>
>> Subject: RE: RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms
>> after JDK-8227512
>>> ProblemList-graal.txt files don't use any magic at all, neither do they
>> depend
>>> VMProps, special jtreg or VM technology. these are just extra problem list
>>> files, which you are supposed to add into your command lines whenever
>> you
>>> are using Graal .
>> Thanks Igor and Jon for your explanation.
>> Christoph, would you like to add a ProblemList-graal.txt file and remove my
>> added modules in your JDK-8228571? I see this is also your alternative fix.
>> --
>> Thanks,
>> Pengfei

More information about the compiler-dev mailing list