JDK 14 RFR of JDK-8233096: Update javax.lang.model for switch expressions
jan.lahoda at oracle.com
Wed Nov 13 22:47:49 UTC 2019
Looks good to me. Thanks for taking care of this!
On 13. 11. 19 4:50, Joe Darcy wrote:
> Hi Jon,
> Re-refactored test to cut down on code duplication:
> On 11/12/2019 5:43 PM, Jonathan Gibbons wrote:
>> Hi Joe,
>> There seems to be a lot of repeated code in the test, perhaps because
>> it has been slowly growing over the years.
>> It might be worth considering using an enum to encapsulate the
>> properties/predicate/name of "keyword" vs "name".
>> It also seems like the check calls always come in pairs for true/false
>> for the first argument. In conjunction with the previous suggestion,
>> this could maybe be simplified as well.
>> -- Jon
>> On 11/12/19 3:37 PM, Joe Darcy wrote:
>>> Coming back to this after the switch expression changes were pushed,
>>> I've updated the test to give a more informative output message on an
More information about the compiler-dev