RFR: JDK-8230918: j.l.NASE in javap
vicente.romero at oracle.com
Tue Aug 25 17:54:37 UTC 2020
On 8/20/20 5:30 PM, Vicente Romero wrote:
> Hi Jon,
> Thanks for the review, I have updated the review to  to address
> your comments,
>  http://cr.openjdk.java.net/~vromero/8230918/webrev.01/
> On 8/19/20 8:49 PM, Jonathan Gibbons wrote:
>> Hi Vicente,
>> It seems wrong to hijack an existing exception for an unrelated use.
>> There's no IO condition that warrants the use of
>> `java.io.IOException`. The problem is that for better or worse, javap
>> cannot handle this probably-malformed class file. That deserves some
>> appropriate exception, and a new one if there is nothing appropriate
>> that is already available to use.
>> -- Jon
>> On 8/19/20 5:24 PM, Vicente Romero wrote:
>>> Please review fix for  at . The fix is making javac fail with
>>> an error message if an attribute has a length too big to be processed.
More information about the compiler-dev