RFR: 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Thu Dec 3 08:22:56 UTC 2020

On Tue, 20 Oct 2020 05:38:27 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Hello,
>> Thank you for the contribution.
>> As you can see from the @Target javadoc ( https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/annotation/Target.html ) there is some ambiguity here. I have rased a separate discussion on compiler-dev, depending on the outcome of that discussion this patch will need to be revised.
> Thanks for focusing on this patch. I will continue to follow the discussion and revise my patch based on the outcome of the discussion.

> Short term (Java 16) it makes sense to fix https://bugs.openjdk.java.net/browse/JDK-8254023 given that both competing specs agree for this case, it is a small fix, and externally found.
>For Java 17 we should align both specs and the reference implementation one way or another.

@jbf According to your comments, I revise my code to only fix JDK-8254023.
The rest of the work, ambiguity of the specifications, will be clarified and fixed in Java 17.
Thank you for taking the time to review.


PR: https://git.openjdk.java.net/jdk/pull/622

More information about the compiler-dev mailing list