RFR: 8257037: No javac warning when calling deprecated constructor with diamond [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Fri Dec 4 19:14:17 UTC 2020

On Wed, 2 Dec 2020 12:15:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>>>  Is the code `newConstr.setAttributes(sym);` necessary in `Resolve.findDiamond`?
>> Sorry, that was a leftover from a previous experiment. That's not necessary. We'll run some more tests on our side and I'll let you know.
>> @mcimadamore Should I add you as a contributor of this patch? Does it need another reviewer to review if I add you as a contributor?
> As you prefer - I don't mind either way. I don't think adding me as a contributor should prevent the integration, or me being able to sponsor, but I'm not 100% sure.

I revise the test code based on the comment[1] written by Jonathan Gibbons in JDK-8231622[2].

> For tests that use /ref=file -XDrawDiagnostics the conventions are:
>   1. Omit the complete legal header, including the copyright and license
>   2. After `@test` add the text `/nodynamiccopyright/`
> #1 protects the file against any future changes in the length of the legal header, that might affect line numbers, and #2 is for use by automated scripts that may check for the presence of the legal header.

[1] https://mail.openjdk.java.net/pipermail/compiler-dev/2020-December/015542.html
[2] https://github.com/openjdk/jdk/pull/1626


PR: https://git.openjdk.java.net/jdk/pull/1490

More information about the compiler-dev mailing list