RFR: 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation

Vicente Romero vromero at openjdk.java.net
Mon Dec 7 15:55:19 UTC 2020

On Thu, 3 Dec 2020 08:20:13 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Thanks for focusing on this patch. I will continue to follow the discussion and revise my patch based on the outcome of the discussion.
>> Short term (Java 16) it makes sense to fix https://bugs.openjdk.java.net/browse/JDK-8254023 given that both competing specs agree for this case, it is a small fix, and externally found.
>>For Java 17 we should align both specs and the reference implementation one way or another.
> @jbf According to your comments, I revise my code to only fix JDK-8254023.
> The rest of the work, ambiguity of the specifications, will be clarified and fixed in Java 17.
> Thank you for taking the time to review.

the change looks good but I'm surprised that no other tests are failing and need changes, in particular tests like:  `test/langtools/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java`


PR: https://git.openjdk.java.net/jdk/pull/622

More information about the compiler-dev mailing list