RFR: 8231622: SuppressWarning("serial") ignored on field serialVersionUID [v3]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Tue Dec 8 13:02:33 UTC 2020

> Hi all,
> Currently, a warning is generated when compiling the following code by using the option `-Xlint`.
> import java.io.Serializable;
> class B implements Serializable {
>     @SuppressWarnings("serial")
>     private static final byte serialVersionUID = 5;
> }
> output:
> B.java:4: warning: [serial] serialVersionUID must be of type long in class B
>     private static final byte serialVersionUID = 5;
>                               ^
> 1 warning
> The annotation `@SuppressWarnings("serial")` on  field serialVersionUID is ignored by the compiler.
> This patch fixes it and adds some tests.
> Thank you for taking the time to review.
> Best Regards.

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Revise tests by using library toolbox.
 - Merge remote-tracking branch 'origin' into JDK-8231622
 - Revise test cases. Remove legal header and add /nodynamiccopyright/
 - 8231622: SuppressWarning(serial) ignored on field serialVersionUID


  - all: https://git.openjdk.java.net/jdk/pull/1626/files
  - new: https://git.openjdk.java.net/jdk/pull/1626/files/16eeaa56..752ccba4

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1626&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1626&range=01-02

  Stats: 14872 lines in 368 files changed: 9645 ins; 3818 del; 1409 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1626.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1626/head:pull/1626

PR: https://git.openjdk.java.net/jdk/pull/1626

More information about the compiler-dev mailing list