RFR: 8231622: SuppressWarning("serial") ignored on field serialVersionUID [v2]
github.com+13688759+lgxbslgx at openjdk.java.net
Tue Dec 8 13:05:12 UTC 2020
On Mon, 7 Dec 2020 19:21:00 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> Revise test cases. Remove legal header and add /nodynamiccopyright/
> I approve these changes.
> That being said, a more modern idiom for negative tests involving small source files and corresponding small golden files, is to write a single file that uses library code like `toolbox.ToolBox` to write files on the fly, perhaps from content in a text block, and to compare the output against another text block. For slightly more advanced usage, you can compile strings directly using API like `SimpleJavaFileObject`, and avoid the file system altogether.
@jonathan-gibbons I revise the test code by using the library toolbox. Thank you for taking the time to review.
More information about the compiler-dev