RFR: 8257733: Move module-specific data from make to respective module [v2]
mchung at openjdk.java.net
Tue Dec 8 18:20:07 UTC 2020
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into java.base as well?
>> Update: I see all subdirs in tools are still there.
> @wangweij Moving build tools is a related, but separate, question, which is addressed by https://bugs.openjdk.java.net/browse/JDK-8241463.
> I send out a review earlier this year (see https://mail.openjdk.java.net/pipermail/build-dev/2020-March/027038.html), but there were differing opinions on what the proper placement of these tools should be, and the discussion kind of fizzled out without reaching a conclusion.
@magicus @erikj79 it's now clearly stated that you want everything under `make` owned by the build team, which is fair. You are right that `make` has been easily considered as a dumping ground and it's time to define a clean structure.
I reviewed this patch and this looks okay to me. Some follow-up questions and follow-on cleanup for example "should jdwp.spec belong to `specs` directory vs `data`? There are platform-specific data (such as charsets) which has been special-case in the makefile and they need follow-on clean up. I agree that this should be cleaned up by the component teams and not part of this PR.
More information about the compiler-dev