RFR: 8257733: Move module-specific data from make to respective module [v2]
naoto at openjdk.java.net
Thu Dec 10 23:10:57 UTC 2020
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module. For instance, the publicsuffixlist is used by java.base, and fontconfig by java.desktop. (A few directories, like mainmanifest, is *actually* used by make for the whole build.)
>> These data files should move to the module they belong to. The are, after all, "source code" for that module that is "compiler" into resulting deliverables, for that module. (But the "source code" language is not Java or C, but typically a highly domain specific language or data format, and the "compilation" is, often, a specialized transformation.)
>> This misplacement of the data directory is most visible at code review time. When such data is changed, most of the time build-dev (or the new build label) is involved, even though this has nothing to do with the build. While this is annoying, a worse problem is if the actual team that needs to review the patch (i.e., the team owning the module) is missed in the review.
>> ### Modules reviewed
>> - [ ] java.base
>> - [ ] java.desktop
>> - [x] jdk.compiler
>> - [ ] java.se
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> Move to share/data, and move jdwp.spec to java.se
Reviewed changes to `characterdata`, `charsetmapping`, `cldr`, `currency`, `lsrdata`, `tzdata`, and `unicodedata` with minor comment. Looks good overall.
test/jdk/java/util/Locale/LSRDataTest.java line 57:
> 55: // path to the lsr file from the make folder, this test relies on the
> 56: // relative path to the file in the make folder, considering
> 57: // test and make will always exist in the same jdk layout
The comment refers to the "make" folder. (line 55 as well).
Marked as reviewed by naoto (Reviewer).
More information about the compiler-dev