RFR: 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation [v3]
github.com+13688759+lgxbslgx at openjdk.java.net
Fri Dec 11 15:49:14 UTC 2020
> Hi all,
> The Java Language Specifications(JLS), from 8 to 13 included, state it as below:
>> If an annotation of type java.lang.annotation.Target is not present on the
> declaration of an annotation type T , then T is applicable in all declaration contexts
> except type parameter declarations, and in no type contexts.
> These contexts are the syntactic locations where annotations were allowed in Java SE 7.
> The JLS 14 and 15 state it as below:
>>If an annotation of type java.lang.annotation.Target is not present on the
> declaration of an annotation type T , then T is applicable in all nine declaration
> contexts and in all 16 type contexts.
> This patch adds `names.MODULE, names.TYPE_PARAMETER, names.TYPE_USE` to `com.sun.tools.javac.comp.Check.dfltTargetMeta` to fix this issue.
> Thank you for taking the time to review.
> Best Regards.
Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
- Add two test cases.
- all: https://git.openjdk.java.net/jdk/pull/622/files
- new: https://git.openjdk.java.net/jdk/pull/622/files/5ff3e252..d7777f4d
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=622&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=622&range=01-02
Stats: 99 lines in 2 files changed: 97 ins; 0 del; 2 mod
Fetch: git fetch https://git.openjdk.java.net/jdk pull/622/head:pull/622
More information about the compiler-dev