[jdk16] RFR: JDK-8247994: Localize javadoc search
Magnus Ihse Bursie
ihse at openjdk.java.net
Tue Dec 15 09:27:59 UTC 2020
On Sun, 13 Dec 2020 00:22:04 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>> The source file `search.js` is renamed to `search.js.template`, and (unlike other template files) is copied as-is into the generated image. The values in the template are resolved when javadoc is executed, depending on the locale in use at the time. Because of the change in the file's extension, two makefiles are updated to accommodate the new extension: one is for the "interim" javadoc used to generate the API docs; the other is for the primary javadoc in the main JDK image.
> make/CompileInterimLangtools.gmk line 77:
>> 75: Standard.java, \
>> 76: EXTRA_FILES := $(BUILDTOOLS_OUTPUTDIR)/gensrc/$1.interim/module-info.java, \
>> 77: COPY := .gif .png .xml .css .js .js.template .txt javax.tools.JavaCompilerTool, \
> Build-folk: it would be nice if this macro could use `$(jdk.javadoc_COPY)` instead of having to duplicate entries.
> (Future RFE?)
I agree. The entire design of CompileJavaModules.gmk needs to be updated. I've been procrastinating on cleaning this up, maybe it's time to get going on it...
More information about the compiler-dev