RFR: 8257733: Move module-specific data from make to respective module [v2]
Magnus Ihse Bursie
ihse at openjdk.java.net
Tue Dec 15 22:56:16 UTC 2020
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> Move to share/data, and move jdwp.spec to java.se
> Reviewed changes to `characterdata`, `charsetmapping`, `cldr`, `currency`, `lsrdata`, `tzdata`, and `unicodedata` with minor comment. Looks good overall.
I think this is almost ready to be pushed, but I'd like to have someone from the client team review the changes for java.desktop as well. @prrace Any change you can have a look at this?
> test/jdk/java/util/Locale/LSRDataTest.java line 57:
>> 55: // path to the lsr file from the make folder, this test relies on the
>> 56: // relative path to the file in the make folder, considering
>> 57: // test and make will always exist in the same jdk layout
> The comment refers to the "make" folder. (line 55 as well).
Fixed. Thank you for noticing!
More information about the compiler-dev