RFR: 8257733: Move module-specific data from make to respective module [v2]
Magnus Ihse Bursie
ihse at openjdk.java.net
Wed Dec 16 14:02:57 UTC 2020
On Wed, 16 Dec 2020 10:12:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> I think this is almost ready to be pushed, but I'd like to have someone from the client team review the changes for java.desktop as well. @prrace Any change you can have a look at this?
> I think it will be annoying to have the charset mapping tables and other data in the src tree, have you looked at other alternatives?
@AlanBateman Let me re-iterate: the data files are *not* "make" files. It is just as annoying to have team-specific data files in the make tree! So to keep things as they are is not an option. The fact that they currently reside there is just a continuation of the old view of make as a general dumping ground. I've requested this change since before Project Jigsaw. In fact, I opposed Erik's original Jigsaw patch on this ground, among other things. As a compromise, we agreed that it was to be fixed *after* Jigsaw, since that project had already dragged out in time for so long and was blocking the release. (See https://bugs.openjdk.java.net/browse/JDK-8055193 for details.)
So what do you propose for alternative? A new top-level data directory? I mean, sure, we could have like `data/java.base/share/charsetmapping` instead. I personally think that makes less sense. I also think that the person most qualified to judge about charsetmapping is @naotoj, which has already accepted this review as it is.
More information about the compiler-dev