RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v2]
jjg at openjdk.java.net
Wed Dec 16 18:29:00 UTC 2020
On Thu, 5 Nov 2020 16:16:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> - Fix merge issues; review feedback
>> - Merge with master
>> - allow rich content in createAnchorAndSearchIndex
>> - update Docs.gmk to stop disabling spec tag
>> - fix TestSpecTag.testEncodedURI
>> - fix tests
>> - remove support to workaround legacy @spec tag
>> - Merge remote-tracking branch 'upstream/master' into new-spec-tag
>> - fix trailing whitespace in test
>> - temporarily allow existing legacy usage `@spec JPMS` `@spec jsr-51`
>> - ... and 1 more: https://git.openjdk.java.net/jdk/compare/804bd725...ed5512d9
> 1. Thanks for incorporating my previous offline feedback.
> 2. Since Hannes and Erik seem to have looked at everything else, I looked mostly at changes in `src/jdk.compiler/share/classes/com/sun/source/**`, which are good!
> 3. There should be a corresponding but separate change to "Documentation Comment Specification for the Standard Doclet".
> 4. Can we use this new `@since` tag to refer to the spec at `com/sun/tools/javac/parser/DocCommentParser.java:1116`?
> 5. Should we specify in `com.sun.source.doctree.SpecTree` that both `url` and `label` parts are mandatory?
> 6. `DCSpec extends DCEndPosTree`, sigh... Although that is not a public API, this design suggests we could improve that abstraction sometime later.
Closing pull request, until we better decide the contents of the spec page
More information about the compiler-dev