[jdk16] RFR: JDK-8247994: Localize javadoc search [v3]

Hannes Wallnöfer hannesw at openjdk.java.net
Thu Dec 17 17:06:00 UTC 2020

On Thu, 17 Dec 2020 16:39:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is for JDK16, as a precursor to fixing JDK-8258002.
>> While it is good to be using localized strings in the generated output, the significance for JDK-8258002 is that the strings are now obtained from a resource file, and not hardcoded in JavaScript file itself.
>> The source file `search.js` is renamed to `search.js.template`, and (unlike other template files) is copied as-is into the generated image. The values in the template are resolved when javadoc is executed, depending on the locale in use at the time. Because of the change in the file's extension, two makefiles are updated to accommodate the new extension: one is for the "interim" javadoc used to generate the API docs; the other is for the primary javadoc in the main JDK image.
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>   Address review comment

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template line 40:

> 38: var MIN_RESULTS = 3;
> 39: var MAX_RESULTS = 500;
> 40: var UNNAMED = "<Unnamed>>";

Oops, an additional closing angle bracket slipped there.


PR: https://git.openjdk.java.net/jdk16/pull/16

More information about the compiler-dev mailing list