RFR: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient

Jonathan Gibbons jjg at openjdk.java.net
Sun Dec 20 20:04:55 UTC 2020

On Sun, 20 Dec 2020 20:00:34 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Hi all,
>> `FilerOutputStream` extends `FilterOutputStream` without overwriting the method `write(byte b[], int off, int len)` which would suffer from the performance problem.
>> This patch fixes it and adds some `@Override` to polish the code. But I can't find a good way to write a corresponding test case. Maybe it doesn't need a test case. And all existing tests in `test/langtools/tools/javac` passed locally.
>> Thank you for taking the time to review.
>> Best Regards.
> Normally, I would leave this to @jddarcy, who wrote this code, but he is currently on vacation.
> I'll approve it with the understanding that I'll help make changes if Joe thinks that any are necessary.

Regarding a test, I agree that one is not practical or necessary. The policy in this case is to mark the JBS issue with one of the `noreg-*` series on labels. `noreg-cleanup` is the appropriate one in this case.


PR: https://git.openjdk.java.net/jdk/pull/1854

More information about the compiler-dev mailing list