RFR: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface [v2]

Vicente Romero vromero at openjdk.java.net
Wed Dec 23 04:39:55 UTC 2020

On Tue, 22 Dec 2020 16:23:14 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Hi all,
>> The method `Types.isCastable` uses method `Types.areDisjoint` to do some check. But `Types.isCastable` doesn't check the type of the parameter before invoking method `Types.areDisjoint`. This patch adds the corresponding check and add a test case.
>> Thank you for taking the time to review.
>> Best Regards.
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Use methods instead of instanceof

the fix looks good to me but we need this code in JDK 16, please create another PR targeting JDK 16 and close this one. Thanks for the fix!


PR: https://git.openjdk.java.net/jdk/pull/1849

More information about the compiler-dev mailing list