RFR: 8247957: remove doclint support for HTML 4 [v5]
ysatowse at openjdk.java.net
Wed Dec 23 05:41:02 UTC 2020
On Wed, 23 Dec 2020 05:01:44 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 5th: 8258460: Remove --doclint-format option from javac
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 736:
>> 735: // https://html.spec.whatwg.org/#the-id-attribute
>> 736: private static final Pattern validId = Pattern.compile("[^\s]+");
> The regular expression is invalid and needs to be fixed. It should be `Pattern.compile("[^\\s]+")`
> Note the extra `` character. This is because you need to escape the `` character in the string constant, so that the `` is seen in the pattern as part of `\s`.
Correct. Thanks a lot for finding this error.
Now that I have doubts why this line could have been compiled without error. This line should cause a compiler error.
Let me review all anchor tests again because the logic should be checked there.
More information about the compiler-dev